Re: [PATCH] kbuild: mkcompile_h: Include $LD version in /proc/version

[Sedat Dilek]

On Thu, Apr 2, 2020 at 4:24 PM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>
> On Thu, Apr 2, 2020 at 10:18 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >
> > When doing Clang builds of the kernel, it is possible to link with
> > either ld.bfd (binutils) or ld.lld (LLVM), but it is not possible to
> > discover this from a running kernel. Add the "$LD -v" output to
> > /proc/version.
> >
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>

Please feel free and add:

Reviewed-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>

When I looked at the original patch of Kees I wondered why
$(KBUILD_CFLAGS) is passed, but Masahiro has a patch for that...

  "[PATCH] kbuild: do not pass $(KBUILD_CFLAGS) to scripts/mkcompile_h"

...see [1].

I have tested with both patches in linux-kbuild.git#kbuild against Linux v5.6.

- Sedat -

[1] https://patchwork.kernel.org/patch/11473667/