Re: [linux-sunxi] [PATCH 0/7] Add support for Allwinner H6 DVFS

[ClÃment PÃron]

Hi,

On Sun, 5 Apr 2020 at 16:54, OndÅej Jirman <megous@xxxxxxxxxx> wrote:
>
> Hi,
>
> On Sun, Apr 05, 2020 at 04:33:37PM +0200, ClÃment PÃron wrote:
> > Hi OndÅej,
>
> [ ... ]
>
> > Good point, this information should be added for both CPU and GPU regulator.
> > This could be nice to confirm this point with a scope.
> >
> > Also I remark that Allwinner user higher temperature than what we set :
> > alarm_low_temp = <105000>;
> > alarm_high_temp = <110000>;
> > alarm_temp_hysteresis = <15000>;
> > shut_temp= <115000>;
> > https://github.com/orangepi-xunlong/OrangePiH6_Linux4_9/blob/master/arch/arm64/boot/dts/sunxi/sun50iw6p1.dtsi#L1924
> >
> > Don't you think that we can push a bit higher the temperature it's
> > actually at 80ÂC ?
>
> We probably can. But just 5ÂC between high temp and criticla temp is probably
> not enough. I'd probably set our value to something like 90-100ÂC so that quick
> temperature spike before regulation kicks in would not shutdown the CPU.

OK I will push it to 85ÂC and leave the critical to 100ÂC.

Test it again and will send a v2

Regards,
ClÃment

>
> regards,
>         o.
>
> > Thanks for the review,
> > Clement
> >