Re: [PATCH] io_uring: fix ctx refcounting in io_submit_sqes()
From: Jens Axboe
Date: Sun Apr 05 2020 - 18:24:29 EST
On 4/5/20 3:08 PM, Pavel Begunkov wrote:
> If io_get_req() fails, it drops a ref. Then, awhile keeping @submitted
> unmodified, io_submit_sqes() breaks the loop and puts @nr - @submitted
> refs. For each submitted req a ref is dropped in io_put_req() and
> friends. So, for @nr taken refs there will be
> (@nr - @submitted + @submitted + 1) dropped.
>
> Remove ctx refcounting from io_get_req(), that at the same time makes
> it clearer.
Applied, but also marked for 5.6 stable.
--
Jens Axboe