Re: [PATCH] vdpa-sim: depend on HAS_DMA

[Jason Wang]

On 2020/4/5 äå4:14, Michael S. Tsirkin wrote:
> set_dma_ops isn't available on all architectures:
>
>          make ARCH=um
> ...
>
>     drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create':
> > > drivers/vdpa/vdpa_sim/vdpa_sim.c:324:2: error: implicit declaration of function 'set_dma_ops'; did you mean 'set_groups'?
> +[-Werror=implicit-function-declaration]
>       set_dma_ops(dev, &vdpasim_dma_ops);
>       ^~~~~~~~~~~
>       set_groups
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
>   drivers/vdpa/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index 08b615f2da39..d0cb0e583a5d 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -14,7 +14,7 @@ if VDPA_MENU
>   
>   config VDPA_SIM
>   	tristate "vDPA device simulator"
> -	depends on RUNTIME_TESTING_MENU
> +	depends on RUNTIME_TESTING_MENU && HAS_DMA
>   	select VDPA
>   	select VHOST_RING
>   	select VHOST_IOTLB


Acked-by: Jason Wang <jasowang@xxxxxxxxxx>