Re: [PATCH] scsi: aic7xxx: Remove null pointer checks before kfree()

From: Qiujun Huang
Date: Sun Apr 05 2020 - 21:14:45 EST


Sorry about nnnnoise, please just ignore it.

On Mon, Apr 6, 2020 at 4:02 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> > NULL check before kfree is unnecessary so remove it.
>
> I hope that you would like to take another update suggestion into account
> (besides a typo correction for your commit message).
> https://lore.kernel.org/patchwork/patch/1220189/
> https://lore.kernel.org/linux-scsi/20200403164712.49579-1-alex.dewar@xxxxxxxxx/
>
> Do you find a previous update suggestion like âSCSI-aic7...: Delete unnecessary
> checks before the function call "kfree"â also interesting?
> https://lore.kernel.org/linux-scsi/54D3E057.9030600@xxxxxxxxxxxxxxxxxxxxx/
> https://lore.kernel.org/patchwork/patch/540593/
> https://lkml.org/lkml/2015/2/5/650
>
> Regards,
> Markus