Re: [GIT PULL] keys: Fix key->sem vs mmap_sem issue when reading key
From: Waiman Long
Date: Sun Apr 05 2020 - 22:39:00 EST
On 4/5/20 1:31 PM, Linus Torvalds wrote:
> On Sun, Apr 5, 2020 at 2:04 AM David Howells <dhowells@xxxxxxxxxx> wrote:
>> Should this be moved into core code, rather than being squirrelled away in
>> security/keys/?
> Yes. I do think that that __kvzfree() function makes sense in general
> (the same way that kzfree does).
>
> I just happen to despise the name, and think that the implementation
> isn't great.
>
> It also probably makes no sense to make it an inline function. It's
> not like that function is done for performance reasons, and it might
> only get worse if we then end up making it cause barriers or something
> for CPU data leakage issues or whatever.
>
> Linus
>
I have just posted a patch that modify the API as suggested. Please let
me know if further change is needed.
Cheers,
Longman