Re: [PATCH v3] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export

[Oliver O'Halloran]

On Mon, Apr 6, 2020 at 11:15 AM Qiujun Huang <hqjagain@xxxxxxxxx> wrote:
>
> On Mon, Apr 6, 2020 at 3:06 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> >
> > > Here needs a NULL check.
> quite obvious?
> >
> > I find this change description questionable
> > (despite of a reasonable patch subject).
> >
> >
> > > Issue found by coccinelle.
> >
> > Would an information like âGenerated by: scripts/coccinelle/null/kmerr.cocciâ
> > be nicer?
> Yeah, but I think It was enough.

I didn't know we had that script in the kernel tree so I think it's a
good to mention that you used it. It might even help idiots like me
who write this sort of bug.

> > Will a patch change log be helpful here?
> I realized I should write some change log, and the change log was meaningless.
> So I left it blank.

The changelog is fine IMO. The point of a changelog is to tell a
reader doing git archeology why a change happened and this is
sufficent for that.

Reviewed-by: Oliver O'Halloran <oohall@xxxxxxxxx>