Re: [PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment

From: Dan Carpenter
Date: Mon Apr 06 2020 - 07:27:35 EST


On Sun, Apr 05, 2020 at 01:22:29PM +0200, Michael Straube wrote:
> Remove unnecessary asignment in SwLedBlink1(). The code path with the
> asignment 'pLed->BlinkTimes = 0' is only executed when
> 'pLed->BlinkTimes' is already zero and the value is not changed between
> the test 'if (pLed->BlinkTimes == 0)' and the asignment.
>

Better to get rid of the bStopBlinking variable and this becomes more
obvious.

regards,
dan carpenter