Re: [PATCH v1] Bluetooth: debugfs option to unset MITM flag

From: Marcel Holtmann
Date: Mon Apr 06 2020 - 08:08:16 EST


Hi Archie,

> The way I implemented it is, if HCI_ENFORCE_MITM_SMP is set (which it
> is by default), then it will assume the default behavior.
> However, if it is toggled to false, then it will not set the MITM flag
> although the io capability supports that.
>
> I am reluctant to use names with "no" on it, especially since it is a
> boolean. But if it is OK then I shall update to HCI_FORCE_NO_MITM,
> this way it will become more separable with the default behavior.
>
> Sure, I will move that to hci_debugfs.c.

I dislike setting a flag for default behavior. So we need the invert here. I want the âforceâ in front of it that it clearly indicates that it is not default behavior. Similar to the force_static_addr flag.

Regards

Marcel