Re: [PATCH v2 2/2] vhost: disable for OABI

[Arnd Bergmann]

On Mon, Apr 6, 2020 at 3:02 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
>
> On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote:
> > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> >
> > >
> > > +config VHOST_DPN
> > > +       bool "VHOST dependencies"
> > > +       depends on !ARM || AEABI
> > > +       default y
> > > +       help
> > > +         Anything selecting VHOST or VHOST_RING must depend on VHOST_DPN.
> > > +         This excludes the deprecated ARM ABI since that forces a 4 byte
> > > +         alignment on all structs - incompatible with virtio spec requirements.
> > > +
> >
> > This should not be a user-visible option, so just make this 'def_bool
> > !ARM || AEABI'
> >
>
> I like keeping some kind of hint around for when one tries to understand
> why is a specific symbol visible.

I meant you should remove the "VHOST dependencies" prompt, not the
help text, which is certainly useful here. You can also use the three lines

     bool
     depends on !ARM || AEABI
     default y

in front of the help text, but those are equivalent to the one-line version
I suggested.

     Arnd