Re: [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver

[Andrzej Hajda]

Hi Adrian,

Due to different ways of work I use different mail client, so forgive me 
if there are some misconfugrations.


W dniu 30.03.2020 oÂ13:35, Adrian Ratiu pisze:
> Hello everyone,
>
> The v5 series is a significantly cleaned up version from v4,
> started by Ezequiel Garcia's suggestion of splitting out the
> regmap infrastructure from the drivers (thank you!).
>
> Turns out no changes are required to the existing drivers and
> the bridge can transparently take care of the layout logic,
> so there's no need to expose the regmap via plat_data anymore.
>
> Starting from this version I also opted to add per-patch
> changelogs. All review comments up to now have been addressed.
>
> Tested on IMX6DL.
>
> Adrian Ratiu (5):
>    drm: bridge: dw_mipi_dsi: add initial regmap infrastructure
>    drm: bridge: dw_mipi_dsi: abstract register access using reg_fields
>    drm: bridge: synopsis: add dsi v1.01 support
>    drm: imx: Add i.MX 6 MIPI DSI host platform driver
>    dt-bindings: display: add i.MX6 MIPI DSI host controller doc
>
>   .../display/imx/fsl,mipi-dsi-imx6.yaml        | 134 ++++
>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 683 +++++++++++++-----


So we have above 400 lines more just to add slightly different register 
layout of v1.01.

Quite big linecount for apparently small (?) functional change - I was 
too lazy to check how many reg fields are really used (some are not used 
at all), but it does not seem to be big enough to justyfy so big change IMO.

I will add more comments in specific patches.


Regards

Andrzej


>   drivers/gpu/drm/imx/Kconfig                   |   7 +
>   drivers/gpu/drm/imx/Makefile                  |   1 +
>   drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c        | 399 ++++++++++
>   5 files changed, 1049 insertions(+), 175 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml
>   create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c
>