Re: [PATCH] perf script report: fix segfault when using DWARF mode
From: Kim Phillips
Date: Mon Apr 06 2020 - 10:28:34 EST
On 4/6/20 7:59 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Apr 06, 2020 at 11:30:23AM +0200, Andreas Gerstmayr escreveu:
>> On 03.04.20 15:16, Andreas Gerstmayr wrote:
>>> On 03.04.20 14:40, Arnaldo Carvalho de Melo wrote:
>>>> Em Thu, Apr 02, 2020 at 02:07:51PM -0500, Kim Phillips escreveu:
>>>>> On 4/2/20 7:54 AM, Andreas Gerstmayr wrote:
>>>>>> When running perf script report with a Python script and a callgraph in
>>>>>> DWARF mode, intr_regs->regs can be 0 and therefore crashing
>>>>>> the regs_map
>>>>>> function.
>>>>>> Added a check for this condition (same check as in
>>>>>> builtin-script.c:595).
>>>>>> Signed-off-by: Andreas Gerstmayr <agerstmayr@xxxxxxxxxx>
>>>>> Tested-by: Kim Phillips <kim.phillips@xxxxxxx>
>>>> Thanks, added this to that patch.
>>> Great, thanks!
>> Ah, I thought you were referring to my initial flamegraph.py perf script.
>> Is there anything I can do to get it merged?
>
> I'll test it today, were there any Tested-by: or Reviewed-by: to that
> flamegraph.py?
I just added mine.
Kim