Re: [PATCH v5 05/10] mm/swap: charge the page when adding to the swap cache

[Joonsoo Kim]

2020ë 4ì 6ì (ì) ìí 8:58, Hillf Danton <hdanton@xxxxxxxx>ëì ìì:
>
>
> On Fri,  3 Apr 2020 14:40:43 +0900 Joonsoo Kim wrote:
> >
> > @@ -153,11 +165,16 @@ int add_to_swap_cache(struct page *page, swp_entry_t entry,
> >               xas_unlock_irq(&xas);
> >       } while (xas_nomem(&xas, gfp));
> >
> > -     if (!xas_error(&xas))
> > +     if (!xas_error(&xas)) {
> > +             mem_cgroup_commit_charge(page, memcg, false, compound);
>
> Add a tp
>                 trace_mm_add_to_swap_cache(page);

Please let me know the reason of this comment. IMO, adding a tracepoint isn't
good idea until it is really necessary since it is considered as
kernel ABI and it
cannot be changed easily.

Thanks.