Re: [PATCH 2/2] mm: make it clear that gfp reclaim modifiers are valid only for sleepable allocations

[Joel Fernandes]

On Fri, Apr 03, 2020 at 12:41:51PM -0700, David Rientjes wrote:
> On Fri, 3 Apr 2020, Michal Hocko wrote:
> 
> > From: Michal Hocko <mhocko@xxxxxxxx>
> > 
> > While it might be really clear to MM developers that gfp reclaim
> > modifiers are applicable only to sleepable allocations (those with
> > __GFP_DIRECT_RECLAIM) it seems that actual users of the API are not
> > always sure. Make it explicit that they are not applicable for
> > GFP_NOWAIT or GFP_ATOMIC allocations which are the most commonly used
> > non-sleepable allocation masks.
> > 
> > Acked-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> > Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
> 
> Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

Reviewed-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>

thanks,

 - Joel