Re: [PATCH 2/2 - v2] MM: Discard NR_UNSTABLE_NFS, use NR_WRITEBACK instead.

From: Michal Hocko
Date: Tue Apr 07 2020 - 03:33:56 EST


On Tue 07-04-20 09:28:19, Neil Brown wrote:
> On Fri, Apr 03 2020, Jan Kara wrote:
> >
> > So I don't think we can just remove lines from procfs files like this. That
> > has a high potential of breaking some userspace app that is not careful
> > enough when parsing the file. So I think that we need to leave there the
> > format string and just replace K(node_page_state(pgdat, NR_UNSTABLE_NFS))
> > with 0.
>
> OK. I assume changing the static trace points isn't a problem though?

It shouldn't be until we learn that somebody depends on it...
--
Michal Hocko
SUSE Labs