Re: [PATCH v2] iio: core: move 'indio_dev->info' null check first
From: Ardelean, Alexandru
Date: Tue Apr 07 2020 - 04:46:07 EST
On Tue, 2020-04-07 at 10:20 +0200, Markus Elfring wrote:
> [External]
>
> > Doesn't fix anything.
>
> Would the change description be nicer without this sentence?
>
That part is slightly debate-able.
I've had my fair-share of comments [during reviews], where others were
asking/saying "is this fixing anything? please state if this is fixing
anything".
So, over time I got the habit of mentioning 'Doesn't fix anything.' if the patch
doesn't fix anything.
So, I'd leave it as-is [if that's possible].
>
> > Just moves this â
>
> I suggest to choose an imperative wording.
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2*n151__;Iw!!A3Ni8CS0y2Y!pMoqZILvWyu87fkNe16Sua0jMrZZK81oQOHENUhyTWZz9UrY4CisyKWSRCPFws0WTm50iQ$
>
I admit, I didn't read that document too much in-depth.
And I probably won't, because I am lazy.
Personally, what I try to do, is guess the maintainer's/community's preferences
over time via interactions.
Things differ slightly from community to community.
Of course, there is some common ground across all communities, and I try to
apply that first.
Then, depending on the flexibility/past-comments from other sent-patches I try
to apply those on top [unless I forget; which I kinda do].
> Regards,
> Markus