Re: [PATCH v2 2/6] ARM: tegra: Add device-tree for ASUS Google Nexus 7

[Thierry Reding]

On Mon, Apr 06, 2020 at 10:41:06PM +0300, Dmitry Osipenko wrote:
[...]
> diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
[...]
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		linux,cma@80000000 {
> +			compatible = "shared-dma-pool";
> +			alloc-ranges = <0x80000000 0x30000000>;
> +			size = <0x10000000>; /* 256MiB */
> +			linux,cma-default;
> +			reusable;
> +		};
> +
> +		ramoops@bfdf0000 {
> +			compatible = "ramoops";
> +			reg = <0xbfdf0000 0x10000>;	/* 64kB */
> +			console-size = <0x8000>;	/* 32kB */
> +			record-size = <0x400>;		/*  1kB */
> +			ecc-size = <16>;
> +		};
> +
> +		trust_zone@bfe00000 {

Given that this is trademarked as "TrustZone", perhaps drop the
underscore?

Other than that, the same comments as for the Acer tablet patch also
apply here.

Thierry

Attachment: signature.asc
Description: PGP signature