Re: [PATCH] scsi: Remove unnecessary calls to memset after dma_alloc_coherent

[Markus Elfring]

>> â
>>> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
>>> @@ -4887,15 +4887,13 @@ qla25xx_set_els_cmds_supported(scsi_qla_host_t *vha)
>>>  	    "Entered %s.\n", __func__);
>>>
>>>  	els_cmd_map = dma_alloc_coherent(&ha->pdev->dev, ELS_CMD_MAP_SIZE,
>>> -	    &els_cmd_map_dma, GFP_KERNEL);
>>> +					 &els_cmd_map_dma, GFP_KERNEL);
>>>  	if (!els_cmd_map) {
>> â
>>
>> I find it safer to integrate such source code reformattings by
>> another update step which will be separated from the proposed deletion
>> of unwanted function calls.
>
> Good point. This whitespace was autoformatted by Coccinelle,
> probably due to my bad SmPL skills.

Some system factors can be involved here.

* The source code formatting can occasionally be improvable
  in further ways (despite of help by a software like Coccinelle).

* A change mixture can become more challenging.

* Would you like to extend your skills in corresponding areas anyhow?

Regards,
Markus