Re: [PATCH v1 17/28] i2c: altera: convert to devm_platform_ioremap_resource

[Thor Thayer]

On 4/7/20 11:37 AM, Dejin Zheng wrote:
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
>
> Signed-off-by: Dejin Zheng <zhengdejin5@xxxxxxxxx>

Acked-by: Thor Thayer <thor.thayer@xxxxxxxxxxxxxxx>

> ---
>   drivers/i2c/busses/i2c-altera.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-altera.c b/drivers/i2c/busses/i2c-altera.c
> index 1de23b4f3809..7c4c836a3228 100644
> --- a/drivers/i2c/busses/i2c-altera.c
> +++ b/drivers/i2c/busses/i2c-altera.c
> @@ -382,7 +382,6 @@ static const struct i2c_algorithm altr_i2c_algo = {
>   static int altr_i2c_probe(struct platform_device *pdev)
>   {
>   	struct altr_i2c_dev *idev = NULL;
> -	struct resource *res;
>   	int irq, ret;
>   	u32 val;
>   
> @@ -390,8 +389,7 @@ static int altr_i2c_probe(struct platform_device *pdev)
>   	if (!idev)
>   		return -ENOMEM;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	idev->base = devm_ioremap_resource(&pdev->dev, res);
> +	idev->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(idev->base))
>   		return PTR_ERR(idev->base);
>