Re: [RFC 1/1] net/mlx5: Fix failing fw tracer allocation on s390

From: Saeed Mahameed
Date: Wed Apr 08 2020 - 15:36:13 EST


On Tue, 2020-04-07 at 10:01 +0200, Niklas Schnelle wrote:
> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger
> kzalloc()
> allocation as done for the firmware tracer will always fail.
>
> Looking at mlx5_fw_tracer_save_trace(), it is actually the driver
> itself
> that copies the debug data into the trace array and there is no need
> for
> the allocation to be contiguous in physical memory. We can therefor
> use
> kvzalloc() instead of kzalloc() and get rid of the large contiguous
> allcoation.
>

This looks fine and very straight forward.. i don't expect any issue
with this.

Please provide a proper "Fixes:" tag and resubmit to net without the
[RFC].

Thanks