Re: [PATCH v5 05/10] mm/swap: charge the page when adding to the swap cache

[Joonsoo Kim]

2020ë 4ì 7ì (í) ìì 11:21, Hillf Danton <hdanton@xxxxxxxx>ëì ìì:
>
>
> On Tue, 7 Apr 2020 09:42:54 +0900 Joonsoo Kim wrote:
> >
> > 2020=EB=85=84 4=EC=9B=94 6=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 8:58, Hi=
> > llf Danton <hdanton@xxxxxxxx>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
> > >
> > >
> > > On Fri,  3 Apr 2020 14:40:43 +0900 Joonsoo Kim wrote:
> > > >
> > > > @@ -153,11 +165,16 @@ int add_to_swap_cache(struct page *page, swp_entr=
> > y_t entry,
> > > >               xas_unlock_irq(&xas);
> > > >       } while (xas_nomem(&xas, gfp));
> > > >
> > > > -     if (!xas_error(&xas))
> > > > +     if (!xas_error(&xas)) {
> > > > +             mem_cgroup_commit_charge(page, memcg, false, compound);
> > >
> > > Add a tp
> > >                 trace_mm_add_to_swap_cache(page);
> >
> > Please let me know the reason of this comment.
>
> It is derived from
>
>         trace_mm_filemap_add_to_page_cache(page);
>
> in __add_to_page_cache_locked().

Maybe, it has it's own purpose and it would not be applied here. If
someone want to add
a tp here, it can be done with a justification, after this patchset.

Thanks.