Re: [PATCH v1 03/28] i2c: owl: convert to devm_platform_ioremap_resource

From: Manivannan Sadhasivam
Date: Thu Apr 09 2020 - 02:07:07 EST


On Wed, Apr 08, 2020 at 12:37:16AM +0800, Dejin Zheng wrote:
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
>
> Signed-off-by: Dejin Zheng <zhengdejin5@xxxxxxxxx>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Thanks,
Mani

> ---
> drivers/i2c/busses/i2c-owl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index b6b5a495118b..c9e7fcac12ae 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -399,15 +399,13 @@ static int owl_i2c_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct owl_i2c_dev *i2c_dev;
> - struct resource *res;
> int ret, irq;
>
> i2c_dev = devm_kzalloc(dev, sizeof(*i2c_dev), GFP_KERNEL);
> if (!i2c_dev)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - i2c_dev->base = devm_ioremap_resource(dev, res);
> + i2c_dev->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(i2c_dev->base))
> return PTR_ERR(i2c_dev->base);
>
> --
> 2.25.0
>