Re: [PATCH] scsi: Remove unnecessary calls to memset after dma_alloc_coherent

[Alex Dewar]

On Tue, Apr 07, 2020 at 06:56:28PM +0200, Markus Elfring wrote:
> >> â
> >>> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> >>> @@ -4887,15 +4887,13 @@ qla25xx_set_els_cmds_supported(scsi_qla_host_t *vha)
> >>>  	    "Entered %s.\n", __func__);
> >>>
> >>>  	els_cmd_map = dma_alloc_coherent(&ha->pdev->dev, ELS_CMD_MAP_SIZE,
> >>> -	    &els_cmd_map_dma, GFP_KERNEL);
> >>> +					 &els_cmd_map_dma, GFP_KERNEL);
> >>>  	if (!els_cmd_map) {
> >> â
> >>
> >> I find it safer to integrate such source code reformattings by
> >> another update step which will be separated from the proposed deletion
> >> of unwanted function calls.
> >
> > Good point. This whitespace was autoformatted by Coccinelle,
> > probably due to my bad SmPL skills.
>
> Some system factors can be involved here.
>
> * The source code formatting can occasionally be improvable
>   in further ways (despite of help by a software like Coccinelle).
>
> * A change mixture can become more challenging.
>
> * Would you like to extend your skills in corresponding areas anyhow?

Sure, I'd love to. Are there any resources you'd recommend? I'm just
starting out with kernel stuff and would be grateful for any pointers
you can offer :-)

Best,
Alex


>
> Regards,
> Markus