Re: [RFC PATCH 2/3] regmap: Add reg_update_bits() support

[Baolin Wang]

Hi Mark,

On Thu, Apr 9, 2020 at 6:45 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Thu, Apr 09, 2020 at 04:57:58PM +0800, Baolin Wang wrote:
> > Add reg_update_bits() support in case some platforms use a special method
> > to update bits of registers.
> >
> > Signed-off-by: Baolin Wang <baolin.wang7@xxxxxxxxx>
> > ---
> >  drivers/base/regmap/regmap-mmio.c | 29 ++++++++++++++++++++++++++++-
> >  drivers/base/regmap/regmap.c      |  1 +
>
> MMIO devices clearly don't physically have an update_bits() operation so
> this should be implemented further up the stack where it applies to all
> buses without physical support.

I understood your concern. But the syscon driver need use the MMIO
devices' resources (such as address mapping, clock management and so
on), if move this to further up stack, I am afraid the update_bits()
can not use the resources in 'struct regmap_mmio_context'. Do you have
any good suggestion? Thanks.

-- 
Baolin Wang