Re: [PATCH] memory: tegra: avoid unused function warnings

From: Thierry Reding
Date: Thu Apr 09 2020 - 11:01:51 EST


On Wed, Apr 08, 2020 at 09:00:30PM +0200, Arnd Bergmann wrote:
> The suspend/resume functions have no callers depending on
> configuration, so they must be marked __maybe_unused to
> avoid these harmless warnings:
>
> drivers/memory/tegra/tegra186.c:1578:12: error: 'tegra186_mc_resume' defined but not used [-Werror=unused-function]
> 1578 | static int tegra186_mc_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~
> drivers/memory/tegra/tegra186.c:1573:12: error: 'tegra186_mc_suspend' defined but not used [-Werror=unused-function]
> 1573 | static int tegra186_mc_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~
>
> Fixes: 177602b00641 ("memory: tegra: Add system sleep support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/memory/tegra/tegra186.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Do you want to apply this to ARM SoC directly or would you prefer if I
collected fixes and send a PR sometime later in the cycle?

If the former:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature