Re: [PATCH v3 4/4] usb: host: Add ability to build new Broadcom STB USB drivers

From: Andy Shevchenko
Date: Thu Apr 09 2020 - 14:48:03 EST


On Thu, Apr 9, 2020 at 9:15 PM Alan Cooper <alcooperx@xxxxxxxxx> wrote:
> On Thu, Apr 9, 2020 at 8:30 AM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Thu, Apr 09, 2020 at 07:49:52AM -0400, Alan Cooper wrote:
> > > On Thu, Apr 9, 2020 at 5:08 AM Andy Shevchenko
> > > <andy.shevchenko@xxxxxxxxx> wrote:
> > > > On Thu, Apr 9, 2020 at 12:52 AM Al Cooper <alcooperx@xxxxxxxxx> wrote:

> > > > > +BROADCOM BRCMSTB USB EHCI DRIVER
> > > > > +M: Al Cooper <alcooperx@xxxxxxxxx>
> > > > > +L: linux-usb@xxxxxxxxxxxxxxx
> > > > > +L: bcm-kernel-feedback-list@xxxxxxxxxxxx
> > > > > +S: Maintained
> > > > > +F: drivers/usb/host/ehci-brcm.*
> > > > > +F: Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> > > >
> > > > This has ordering issues.
> > > > Run parse-maintainer.pl to fix. (Note, it creates by default a new
> > > > file, you might need to run diff manually to see the difference).
> > >
> > > I'm not sure what you mean.
> > > I ran "./scripts/parse-maintainers.pl" and did "diff MAINTAINERS
> > > MAINTAINERS.new" and there are no differences in or around my entry.
> >
> > Perhaps --order should be added.
>
> So you're asking me to swap the following lines?
>
> F: drivers/usb/host/ehci-brcm.*
> F: Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml

Yes, that is correct.

--
With Best Regards,
Andy Shevchenko