Re: [PATCH v3 00/24] firmware: xilinx: Add xilinx specific sysfs interface

[Jolly Shah]

Hi Greg,
Thanks for the review.

> ------Original Message------
> From: 'Greg Kh' <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent:  Wednesday, March 18, 2020 4:54AM
> To: Jolly Shah <jolly.shah@xxxxxxxxxx>
> Cc: Ard.biesheuvel@xxxxxxxxxx <ard.biesheuvel@xxxxxxxxxx>, 
Mingo@xxxxxxxxxx <mingo@xxxxxxxxxx>, Matt@xxxxxxxxxxxxxxxxxxx 
<matt@xxxxxxxxxxxxxxxxxxx>, Sudeep.holla@xxxxxxx <sudeep.holla@xxxxxxx>, 
Hkallweit1@xxxxxxxxx <hkallweit1@xxxxxxxxx>, Keescook@xxxxxxxxxxxx 
<keescook@xxxxxxxxxxxx>, Dmitry.torokhov@xxxxxxxxx 
<dmitry.torokhov@xxxxxxxxx>, Michal Simek <michal.simek@xxxxxxxxxx>, 
Rajan Vaja <rajanv@xxxxxxxxxx>, Linux-arm-kernel@xxxxxxxxxxxxxxxxxxx 
<linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Linux-kernel@xxxxxxxxxxxxxxx 
<linux-kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v3 00/24] firmware: xilinx: Add xilinx specific 
sysfs interface
>
> On Fri, Mar 06, 2020 at 03:47:08PM -0800, Jolly Shah wrote:
> > This patch series adds xilinx specific sysfs interface for below
> > purposes:
> > - Register access
> > - Set shutdown scope
> > - Set boot health status bit
> >
> > Also this patch series removes eemi ops and adds API
> > corresponding to each eemi ops.
>
> I've applied the first 19 patches here, they looked good, thanks for
> doing that work, makes things a lot more "obvious" as to what is going
> on here.
>
> The rest, please see my review comments and redo.

Submitted v4 patchset. It addresses your review comments. Also took care 
of compilation issues observed for first 19 patches.
Please review.

Thanks,
Jolly Shah


> thanks,
>
> greg k-h