Re: [PATCH] net/mlx5: Fix failing fw tracer allocation on s390
From: Saeed Mahameed
Date: Thu Apr 09 2020 - 18:10:31 EST
On Thu, 2020-04-09 at 09:46 +0200, Niklas Schnelle wrote:
> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger
> kzalloc()
> allocation as done for the firmware tracer will always fail.
>
> Looking at mlx5_fw_tracer_save_trace(), it is actually the driver
> itself
> that copies the debug data into the trace array and there is no need
> for
> the allocation to be contiguous in physical memory. We can therefor
> use
> kvzalloc() instead of kzalloc() and get rid of the large contiguous
> allcoation.
>
> Fixes: f53aaa31cce7 ("net/mlx5: FW tracer, implement tracer logic")
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
Applied to net-mlx5, will be submitted to net in my next pull request.
Thanks,
Saeed.