Re: [RFC v2 1/5] block: move main block debugfs initialization to its own file

[Bart Van Assche]

On 2020-04-09 14:45, Luis Chamberlain wrote:
> Single and multiqeueue block devices share some debugfs code. By
> moving this into its own file it makes it easier to expand and audit
> this shared code.

Christoph doesn't like the name "single queue block devices".
Additionally, the legacy (single queue) block layer is gone. Should the
description of this patch perhaps refer to make_request-based drivers
and request-based drivers?

> +/*
> + * Shared debugfs mq / non-mq functionality
> + */

Shared request-based / make_request-based functionality?

Otherwise this patch looks good to me.

Thanks,

Bart.