Re: [PATCH AUTOSEL 5.6 64/68] btrfs: hold a ref on the root in btrfs_recover_relocation

From: David Sterba
Date: Fri Apr 10 2020 - 06:09:47 EST


On Thu, Apr 09, 2020 at 11:46:29PM -0400, Sasha Levin wrote:
> From: Josef Bacik <josef@xxxxxxxxxxxxxx>
>
> [ Upstream commit 932fd26df8125a5b14438563c4d3e33f59ba80f7 ]
>
> We look up the fs root in various places in here when recovering from a
> crashed relcoation. Make sure we hold a ref on the root whenever we
> look them up.
>
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
> Reviewed-by: David Sterba <dsterba@xxxxxxxx>
> Signed-off-by: David Sterba <dsterba@xxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Please drop this patch from all stable versions. It's part of a
larger series that is preparatory switching from SRCU to refcounts, so
the patch on itself does not fix anything.