re: [SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver

[Colin Ian King]

Hi,

Static analysis wit Coverity has found an issue in the following commit:

commit 26780d9e12edf45c0b98315de272b1feff5a8e93
Author: Bradley Grove <bgrove@xxxxxxxxxxxx>
Date:   Fri Aug 23 10:35:45 2013 -0400

    [SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter
Driver

The issue is in function write_fs in drivers/scsi/esas2r/esas2r_main.c
as follows:

101        int result = 0;
102
103        result = esas2r_write_fs(a, buf, off, count);
104
105        if (result < 0)

Unused value (UNUSED_VALUE) assigned_value: Assigning value 0 to result
here, but that stored value is not used.

106                result = 0;
107
108        return length;

I'm not sure what the intention was for this. Was length meant to be
assigned to 0 rather than result?  Or is the result < 0 check just
unnecessary code?

Colin