Re: [PATCH 4/7] kgdboc: Add earlycon_kgdboc to support early kgdb using boot consoles

From: kbuild test robot
Date: Fri Apr 10 2020 - 21:45:39 EST


Hi Douglas,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on tty/tty-testing v5.6 next-20200410]
[cannot apply to kgdb/kgdb-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Douglas-Anderson/kgdb-Support-late-serial-drivers-enable-early-debug-w-boot-consoles/20200411-062123
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/usb/early/ehci-dbgp.c: In function 'kgdbdbgp_parse_config':
>> drivers/usb/early/ehci-dbgp.c:1060:2: error: too few arguments to function 'kgdb_register_io_module'
kgdb_register_io_module(&kgdbdbgp_io_ops);
^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/usb/early/ehci-dbgp.c:24:0:
include/linux/kgdb.h:326:12: note: declared here
extern int kgdb_register_io_module(struct kgdb_io *new_dbg_io_ops,
^~~~~~~~~~~~~~~~~~~~~~~

vim +/kgdb_register_io_module +1060 drivers/usb/early/ehci-dbgp.c

4fe1da4ebc18c4 Jason Wessel 2010-05-20 1046
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1047 static int __init kgdbdbgp_parse_config(char *str)
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1048 {
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1049 char *ptr;
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1050
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1051 if (!ehci_debug) {
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1052 if (early_dbgp_init(str))
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1053 return -1;
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1054 }
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1055 ptr = strchr(str, ',');
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1056 if (ptr) {
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1057 ptr++;
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1058 kgdbdbgp_wait_time = simple_strtoul(ptr, &ptr, 10);
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1059 }
4fe1da4ebc18c4 Jason Wessel 2010-05-20 @1060 kgdb_register_io_module(&kgdbdbgp_io_ops);
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1061 kgdbdbgp_io_ops.is_console = early_dbgp_console.index != -1;
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1062
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1063 return 0;
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1064 }
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1065 early_param("kgdbdbgp", kgdbdbgp_parse_config);
4fe1da4ebc18c4 Jason Wessel 2010-05-20 1066

:::::: The code at line 1060 was first introduced by commit
:::::: 4fe1da4ebc18c4c42fa56c228447f68033fce5f0 echi-dbgp: Add kernel debugger support for the usb debug port

:::::: TO: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
:::::: CC: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip