Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message

From: Joe Perches
Date: Sat Apr 11 2020 - 11:48:59 EST


On Sat, 2020-04-11 at 15:13 +0200, Paul Cercueil wrote:
> Hi Christophe,
>
> Le sam. 11 avril 2020 à 8:38, Christophe JAILLET
> <christophe.jaillet@xxxxxxxxxx> a écrit :
> > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
>
> Is that so?
> From what I could see these macros add the \n themselves if needed.

Not so.

> So the \n were omitted on purpose.

Just a trivial oversight really.

AFAIK: It's an issue _only_ in two cases:

p another process emits a printk with KERN_CONT (or pr_cont)
that might extend this message in the log on the same line.

o this message wukk not be emitted into the log until another
message arrives