Re: [GIT PULL] Rename page_offset() to page_pos()

[Linus Torvalds]

On Sat, Apr 11, 2020 at 2:48 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> I wasn't entirely forthcoming ... I actually want to introduce a new
>
> #define page_offset(page, x) ((unsigned long)(x) & (page_size(page) - 1))

No, no, no.

THAT would be confusing. Re-using a name (even if you renamed it) for
something new and completely different is just bad taste. It would
also be a horrible problem - again - for any stable backport etc.

Just call that "offset_in_page()" and be done with it.

                Linus