RE: [PATCH] i2c: slave: support I2C_SLAVE_STOP event for the read transactions

From: Biwen Li (OSS)
Date: Sun Apr 12 2020 - 21:47:29 EST


>
> Hi,
>
> On Tue, Mar 31, 2020 at 08:48:03AM +0000, Biwen Li (OSS) wrote:
> > > Hi,
> > >
> > > On Mon, Mar 30, 2020 at 10:56:28AM +0000, Biwen Li wrote:
> > > > Hi All,
> > > >
> > > > The patch based on https://patchwork.ozlabs.org/patch/1203640/
> > > > and it is not accepted, so
> > > > it(https://patchwork.ozlabs.org/patch/1203640/)
> > > is needed before apply the new patch.
> > >
> > > I'm not sure what should I do with this information. This links are
> > > to the patch which needed to be update by you, before it can be
> > > reviewed and then hopefully accepted. Why do you sending one more
> > > patch for review for a patch which is not accepted?
> > Hi Oleksij,
> > Okay, got it. I will resend the patch after the old patch is accepted
> > by upstream. Thank you for your reply.
>
> Do you mean the shutdown patch?
No, it is not related with shutdown patch.
>
> > >
> > > > Best Regards,
> > > > Biwen Li
> > > > > Support I2C_SLAVE_STOP event for the read transactions(master
> > > > > read from
> > > > > slave)
> > > > >
> > > > > Signed-off-by: Biwen Li <biwen.li@xxxxxxx>
> > > > > ---
> > > > > drivers/i2c/busses/i2c-imx.c | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/drivers/i2c/busses/i2c-imx.c
> > > > > b/drivers/i2c/busses/i2c-imx.c index
> > > > > 62517a41b32d..1fd0d87885d5 100644
> > > > > --- a/drivers/i2c/busses/i2c-imx.c
> > > > > +++ b/drivers/i2c/busses/i2c-imx.c
> > > > > @@ -1464,6 +1464,7 @@ static irqreturn_t
> > > > > i2c_imx_slave_isr(struct imx_i2c_struct *i2c_imx)
> > > > > ctl &= ~I2CR_MTX;
> > > > > imx_i2c_write_reg(ctl, i2c_imx, IMX_I2C_I2CR);
> > > > > imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR);
> > > > > + i2c_slave_event(i2c_imx->slave, I2C_SLAVE_STOP, &value);
> > > > > }
> > > > > return IRQ_HANDLED;
> > > > > }
> > > > > --
> > > > > 2.17.1
> > >
> > > Regards,
> > > Oleksij
> > > --
> > > Pengutronix e.K. |
> > > |
> > > Steuerwalder Str. 21 |
> http://www.pengutronix.de/
> > > |
> > > 31137 Hildesheim, Germany | Phone:
> > > +49-5121-206917-0 |
> > > Amtsgericht Hildesheim, HRA 2686 | Fax:
> > > +49-5121-206917-5555 |
>
> --
> Pengutronix e.K. |
> |
> Steuerwalder Str. 21 | http://www.pengutronix.de/
> |
> 31137 Hildesheim, Germany | Phone:
> +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:
> +49-5121-206917-5555 |