RE: [PATCH v2] exfat: replace 'time_ms' with 'time_10ms'

[Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx]

> Please leave at least 24 hours between sending new versions so that
> you can collect all feedback relating to your change, and we don't see
> discussion fragment between different threads.

Thanks for good advice!

> > +		ts->tv_sec += (time_10ms * 10) / 1000;
> > +		ts->tv_nsec = (time_10ms * 10) % 1000 * NSEC_PER_MSEC;
> 
> I find this more confusing than the original.

The parentheses were intended to group conversions into milliseconds, 
but were not necessary from an "operator precedence" perspective.


> 
> 		ts->tv_sec += time_10ms / 100;
> 		ts->tv_nsec = (time_10ms % 100) * 10 * NSEC_PER_MSEC;
> 
> is easier to understand for me, not least because I don't need to worry
> about the operator precedence between % and *.

If I use '100' for the divisor of '10ms', I find it difficult to understand 
the meaning of the operation.

When using '100' for the divisor, I think cs (centi-sec) is easier to understand than 10ms.
Which do you prefer, time_10ms or time_cs?


BR
---
Kohada Tetsuhiro <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx>