Re: [PATCH] Staging: Comedi: Drivers: das08: Fixed some coding style issues

From: Greg KH
Date: Mon Apr 13 2020 - 08:53:33 EST


On Mon, Apr 13, 2020 at 10:05:55AM +0200, carlosteniswarrior@xxxxxxxxx wrote:
> Fixed a coding style issue caused by some declarations that weren't separated.
>
> Signed-off-by: Carlos Guerrero Alvarez <carlosteniswarrior@xxxxxxxxx>

Your From: line in your email client does not match with this :(

> ---
> drivers/staging/comedi/drivers/das08.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/das08.c b/drivers/staging/comedi/drivers/das08.c
> index 65e5f2e6c122..f884f5841788 100644
> --- a/drivers/staging/comedi/drivers/das08.c
> +++ b/drivers/staging/comedi/drivers/das08.c
> @@ -141,7 +141,9 @@ static const struct comedi_lrange *const das08_ai_lranges[] = {
> static const int das08_pgh_ai_gainlist[] = {
> 8, 0, 10, 2, 12, 4, 14, 6, 1, 3, 5, 7
> };
> +
> static const int das08_pgl_ai_gainlist[] = { 8, 0, 2, 4, 6, 1, 3, 5, 7 };
> +
> static const int das08_pgm_ai_gainlist[] = { 8, 0, 10, 12, 14, 9, 11, 13, 15 };

What is wrong with the original code? It makes more sense, don't you
think?

greg k-h