Re: [PATCH v2 1/2] staging: vt6656: Refactor the assignment of the phy->signal variable
From: Oscar Carter
Date: Mon Apr 13 2020 - 10:25:27 EST
On Mon, Apr 13, 2020 at 02:56:16PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote:
> > Create a constant array with the values of the "phy->signal" for every
> > rate. Remove all "phy->signal" assignments inside the switch statement
> > and replace these with a single reading from the new vnt_phy_signal
> > array.
> >
> > The constant array can be of one dimension because the OR mask with
> > BIT(3) or BIT(4) allow obtain a second value according to the rate,
> > the preamble_type and the pkt_type.
> >
> > Signed-off-by: Oscar Carter <oscar.carter@xxxxxxx>
> > ---
> > drivers/staging/vt6656/baseband.c | 105 ++++++++----------------------
> > 1 file changed, 26 insertions(+), 79 deletions(-)
>
> This series did not apply to my tree, please rebase and resend.
Rebase the patchs is a normal process in the development or am I doing something
wrong ?
>
> thanks,
>
> greg k-h
thanks,
oscar carter