Re: [PATCH] power: supply: max14656: remove set but not used 'ret'

[Sebastian Reichel]

Hi,

On Thu, Apr 09, 2020 at 04:54:01PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
> 
> drivers/power/supply/max14656_charger_detector.c:142:6: warning:
> variable âretâ set but not used [-Wunused-but-set-variable]
>   int ret = 0;
>       ^~~
> 
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/max14656_charger_detector.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/max14656_charger_detector.c b/drivers/power/supply/max14656_charger_detector.c
> index 3bbb8b4c8ae7..137f9fafce8c 100644
> --- a/drivers/power/supply/max14656_charger_detector.c
> +++ b/drivers/power/supply/max14656_charger_detector.c
> @@ -139,10 +139,9 @@ static void max14656_irq_worker(struct work_struct *work)
>  
>  	u8 buf[REG_TOTAL_NUM];
>  	u8 chg_type;
> -	int ret = 0;
>  
> -	ret = max14656_read_block_reg(chip->client, MAX14656_DEVICE_ID,
> -				      REG_TOTAL_NUM, buf);
> +	max14656_read_block_reg(chip->client, MAX14656_DEVICE_ID,
> +				REG_TOTAL_NUM, buf);
>  
>  	if ((buf[MAX14656_STATUS_1] & STATUS1_VB_VALID_MASK) &&
>  		(buf[MAX14656_STATUS_1] & STATUS1_CHG_TYPE_MASK)) {
> -- 
> 2.17.2
>

Attachment: signature.asc
Description: PGP signature