Re: [PATCH 2/2] dt-bindings: iio/dac: ltc2632.txt

[Chris Ruehl]

Jonathan,

On 12/4/2020 7:05 pm, Jonathan Cameron wrote:
> On Wed,  8 Apr 2020 16:10:24 +0800
> Chris Ruehl <chris.ruehl@xxxxxxxxxxxx> wrote:
>
> > This patch add support for Analog Devices (Linear Technology)
> > LTC26234 Quad 12-/10-/8-Bit Rail-to-Rail DAC.
> > Update ltc2632.txt with the expansions for it.
> >
> > Signed-off-by: Chris Ruehl <chris.ruehl@xxxxxxxxxxxx>
> Looks fine.
>
> We need to convert this over to yaml at somepoint.  If you are feeling
> particularly generous and want to do it would be much appreciated but
> it certainly isn't a requirement just to add IDs :)
>
> thanks,
>
> jonathan

No concerns about conversion, I had a typo in the description.
LTC26234 is LTC2634 :) let me make a v2 and make the conversion.

Cheers.

> > ---
> >   Documentation/devicetree/bindings/iio/dac/ltc2632.txt | 8 +++++++-
> >   1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> > index 338c3220f01a..1ab9570cf219 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> > +++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> > @@ -1,4 +1,4 @@
> > -Linear Technology LTC2632/2636 DAC
> > +Linear Technology LTC2632/2634/2636 DAC
> >   
> >   Required properties:
> >    - compatible: Has to contain one of the following:
> > @@ -8,6 +8,12 @@ Required properties:
> >   	lltc,ltc2632-h12
> >   	lltc,ltc2632-h10
> >   	lltc,ltc2632-h8
> > +	lltc,ltc2634-l12
> > +	lltc,ltc2634-l10
> > +	lltc,ltc2634-l8
> > +	lltc,ltc2634-h12
> > +	lltc,ltc2634-h10
> > +	lltc,ltc2634-h8
> >   	lltc,ltc2636-l12
> >   	lltc,ltc2636-l10
> >   	lltc,ltc2636-l8

--
GTSYS Limited RFID Technology
9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2,
42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong
Tel (852) 9079 9521

Disclaimer: https://www.gtsys.com.hk/email/classified.html