Re: [PATCH V7 2/9] fs: Remove unneeded IS_DAX() check in io_is_direct()

From: Christoph Hellwig
Date: Tue Apr 14 2020 - 02:22:20 EST


On Sun, Apr 12, 2020 at 10:40:39PM -0700, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Remove the check because DAX now has it's own read/write methods and
> file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on
> their own. Therefore, it does not matter if the file state is DAX when
> the iocb flags are created.
>
> Also remove io_is_direct() as it is just a simple flag check.
>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>