Re: [External] Re: [PATCH] mm/ksm: Fix a null pointer dereference

From: Muchun Song
Date: Tue Apr 14 2020 - 03:19:59 EST


On Tue, Apr 14, 2020 at 3:14 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> > The find_mergeable_vma can return NULL. In this case, it leads
> > to crash when we access vma->vm_mm(which's offset is 0x40) in
>
> I suggest to improve the commit message.
>
> * Wording alternative:
> to a crash when we access vma->vm_mm (its offset is 0x40) in
>
> * Can a function name be nicer than the information âat 0000000000000040â
> in the patch subject?
>
> * Would you like to add the tag âFixesâ to the change description?
>

Thanks for your suggestion. I will send a v2 patch later.


--
Yours,
Muchun