Re: [PATCH 07/23] floppy: use symbolic register names in the sparc64 port

From: Denis Efremov
Date: Tue Apr 14 2020 - 05:21:13 EST


Hi,

On 3/31/20 12:40 PM, Willy Tarreau wrote:
- printk("floppy: Asked to read unknown port %lx\n", port);
> + printk("floppy: Asked to read unknown port %lx\n", reg);

> - printk("floppy: Asked to write to unknown port %lx\n", port);
> + printk("floppy: Asked to write to unknown port %lx\n", reg);

sparc64 showed a couple of warnings in printks (I will send fixes)
./arch/sparc/include/asm/floppy_64.h: In function âsun_82077_fd_inbâ:
./arch/sparc/include/asm/floppy_64.h:106:48: warning: format â%lxâ expects argument of type âlong unsigned intâ, but argument 2 has type âunsigned intâ [-Wformat=]
106 | printk("floppy: Asked to read unknown port %lx\n", reg);
| ~~^ ~~~
| | |
| | unsigned int
| long unsigned int
| %x
./arch/sparc/include/asm/floppy_64.h: In function âsun_82077_fd_outbâ:
./arch/sparc/include/asm/floppy_64.h:125:52: warning: format â%lxâ expects argument of type âlong unsigned intâ, but argument 2 has type âunsigned intâ [-Wformat=]
125 | printk("floppy: Asked to write to unknown port %lx\n", reg);
| ~~^ ~~~
| | |
| | unsigned int
| long unsigned int
| %x

A couple of new warnings.