Re: [PATCH] vhost: do not enable VHOST_MENU by default

[Jason Wang]

On 2020/4/14 äå3:26, Christian Borntraeger wrote:
> On 14.04.20 04:44, Jason Wang wrote:
> > We try to keep the defconfig untouched after decoupling CONFIG_VHOST
> > out of CONFIG_VIRTUALIZATION in commit 20c384f1ea1a
> > ("vhost: refine vhost and vringh kconfig") by enabling VHOST_MENU by
> > default. Then the defconfigs can keep enabling CONFIG_VHOST_NET
> > without the caring of CONFIG_VHOST.
> >
> > But this will leave a "CONFIG_VHOST_MENU=y" in all defconfigs and even
> > for the ones that doesn't want vhost. So it actually shifts the
> > burdens to the maintainers of all other to add "CONFIG_VHOST_MENU is
> > not set". So this patch tries to enable CONFIG_VHOST explicitly in
> > defconfigs that enables CONFIG_VHOST_NET and CONFIG_VHOST_VSOCK.
> >
> > Cc: Thomas Bogendoerfer<tsbogend@xxxxxxxxxxxxxxxx>
> > Cc: Benjamin Herrenschmidt<benh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Paul Mackerras<paulus@xxxxxxxxx>
> > Cc: Michael Ellerman<mpe@xxxxxxxxxxxxxx>
> > Cc: Heiko Carstens<heiko.carstens@xxxxxxxxxx>
> > Cc: Vasily Gorbik<gor@xxxxxxxxxxxxx>
> > Cc: Christian Borntraeger<borntraeger@xxxxxxxxxx>
> Fine with me.
> s390 part
>
> Acked-by: Christian Borntraeger<borntraeger@xxxxxxxxxx>
>
>   That was my first approach to get things fixed before I reported
> this to you.


Exactly.

Thanks

>