Re: [PATCH] ASoC: tas571x: disable regulators on failed probe

[Mark Brown]

On Tue, Apr 14, 2020 at 01:27:54PM +0200, Philipp Puschmann wrote:
> If probe fails after enabling the regulators regulator_put is called for
> each supply without having them disabled before. This produces some
> warnings like
> 
> WARNING: CPU: 0 PID: 90 at drivers/regulator/core.c:2044 _regulator_put.part.0+0x154/0x15c
> [<c010f7a8>] (unwind_backtrace) from [<c010c544>] (show_stack+0x10/0x14)
> [<c010c544>] (show_stack) from [<c012b640>] (__warn+0xd0/0xf4)
> [<c012b640>] (__warn) from [<c012b9b4>] (warn_slowpath_fmt+0x64/0xc4)
> [<c012b9b4>] (warn_slowpath_fmt) from [<c04c4064>] (_regulator_put.part.0+0x154/0x15c)

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

Attachment: signature.asc
Description: PGP signature