Re: [PATCH 3/8] signal: replace __copy_siginfo_to_user32 with to_compat_siginfo

[Arnd Bergmann]

On Tue, Apr 14, 2020 at 9:01 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> Move copying the siginfo to userspace into the callers, so that the
> compat_siginfo conversion can be reused by the ELF coredump code without
> set_fs magic.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks all good to me, but I noticed that the naming is now a bit
inconsistent. to_compat_siginfo() is basically the reverse of
post_copy_siginfo_from_user32(), but the names are very different.

I suppose this can always be cleaned up later though, as your
naming choice is more consistent with how things are in the
rest of the kernel these days.

    Arnd