Re: [PATCH net 4/4] net: dsa: b53: Rework ARL bin logic

From: Andrew Lunn
Date: Tue Apr 14 2020 - 10:16:25 EST


On Mon, Apr 13, 2020 at 09:16:30PM -0700, Florian Fainelli wrote:
> When asking the ARL to read a MAC address, we will get a number of bins
> returned in a single read. Out of those bins, there can essentially be 3
> states:
>
> - all bins are full, we have no space left, and we can either replace an
> existing address or return that full condition
>
> - the MAC address was found, then we need to return its bin index and
> modify that one, and only that one
>
> - the MAC address was not found and we have a least one bin free, we use
> that bin index location then
>
> The code would unfortunately fail on all counts.
>
> Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew