Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()

From: Andy Shevchenko
Date: Tue Apr 14 2020 - 12:20:19 EST


On Tue, Apr 14, 2020 at 11:50:47PM +0800, Dejin Zheng wrote:
> On Tue, Apr 14, 2020 at 05:38:37PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 14, 2020 at 10:26:50PM +0800, Dejin Zheng wrote:
> > > it will print an error message by itself when platform_get_irq()
> > > goes wrong. so don't need dev_err() in here again.
> >
> > In the future, please use something like this
> > scripts/get_maintainer.pl --git --git-min-percent=67
> > when retrieve Cc list for the mail.
> >
> Andy, Thank you for reminding me again, if I used it, There are only two
> email addresses.
>
> scripts/get_maintainer.pl --git --git-min-percent=67 v1-0001-i2c-img-scb-remove-duplicate-dev_err.patch
> linux-i2c@xxxxxxxxxxxxxxx (open list:I2C SUBSYSTEM HOST DRIVERS)
> linux-kernel@xxxxxxxxxxxxxxx (open list)

Nice, you found a bug in MAINTAINERS database.

> > FWIW,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> Thanks very much for your review.

I recommend to resend a new version with those mailings lists followed by
Wolfram included in the Cc list. Don't forget to add my tag in the commit
message and bump the version.

--
With Best Regards,
Andy Shevchenko