Re: [PATCH] x86: microcode: fix return value for microcode late loading

From: Peter Zijlstra
Date: Tue Apr 14 2020 - 12:24:36 EST


On Tue, Apr 14, 2020 at 12:55:35PM +0300, Mihai Carabas wrote:
> The return value from stop_machine might not be consistent.
>
> stop_machine_cpuslocked returns:
> - zero if all functions have returned 0
> - a non-zero value if at least one of the functions returned
> a non-zero value
>
> There is no way to know if it is negative or positive. So make
> __reload_late return 0 on success, or negative otherwise.
>
> Signed-off-by: Mihai Carabas <mihai.carabas@xxxxxxxxxx>

Isn't the right fix to disable late-loading?