Re: [PATCH 2/2 v8] iio: Add SEMTECH SX9310/9311 sensor driver

[Daniel Campello]

On Tue, Apr 14, 2020 at 3:11 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Apr 14, 2020 at 1:56 AM Daniel Campello <campello@xxxxxxxxxx> wrote:
> > On Fri, Apr 10, 2020 at 4:52 AM Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:
> > > On Thu, Apr 9, 2020 at 2:54 AM Daniel Campello <campello@xxxxxxxxxxxx> wrote:
>
> As far I understand you agreed on the rest.
> Correct?
>
Yes, sorry for not be explicit before.
> ...
>
> > > > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> > > > Signed-off-by: Enrico Granata <egranata@xxxxxxxxxxxx>
> > >
> > > This is not understandable. Are they who helped you develop the code
> > > (we have a special tag, i.e. Co-developed-by in addition to SoB), or
> > > just people in the middle? Then the question is, how come author is
> > > you and not Gwendal?
> > >
> > This patch was initially developed by Gwendal and Enrico (here:
> > crrev.com/c/1089826).
>
> So, tags should include
>  SoB: Gwendal ...
>  Co-developed-by: Enrico ...
>  SoB: Enrico ...
>  Co-developed-by: yours (if you developed it)
>  SoB: yours
>
> and on top git commit --amend --author="Gwendal  ..."

I sent v10 with this metadata changed. Thanks!
>
> ...
>
> > > > +#define SX9310_REG_IRQ_MSK                             0x03
> > >
> > > Is MSK abbreviation in datasheet? Please spell it how it's in datasheet.
> > Yes, they indead use MSK.
>
> Okay!
>
>
> --
> With Best Regards,
> Andy Shevchenko

Regards,
Daniel